Dear all,
We are currently working on the trending of the TPC. We noticed there is already a convenience class TrendingTask
implemented in QualityControl/Framework/
to do some basic trending and we have some questions about its current status:
- At the moment, every histogram which should be trended is passed one by one in the dataSources, in the json file (e.g.
postprocessing.json
,ExampleTrend
, inQualityControl/Framework
), and thus, this causes a lot of code duplication. We want to test the trending of two PID histograms, which have the same paths and reductors and this gives in our json file:
"dataSources": [
{
"type": "repository",
"path": "qc/TPC/PID",
"name": "hNClusters",
"reductorName": "o2::quality_control_modules::common::TH1Reductor",
"moduleName": "QcCommon"
},
{
"type": "repository",
"path": "qc/TPC/PID",
"name": "hPhi",
"reductorName": "o2::quality_control_modules::common::TH1Reductor",
"moduleName": "QcCommon"
},
{
"type": "repository-quality",
"path": "qc/TPC/PID",
"name": "hNClusters",
"reductorName": "o2::quality_control_modules::common::QualityReductor",
"moduleName": "QcCommon"
}
],
Other tasks like the checkers are passing vectors of MOs, which reduce the amount of duplicated information in the json file (see QualityControl/Modules/TPC/run/tpcQCClusterChecker.json
):
"checks": {
"PIDClusterCheck": {
"active": "true",
"className": "o2::quality_control_modules::tpc::PIDClusterCheck",
"moduleName": "QcTPC",
"policy": "OnAny",
"dataSource": [{
"type": "Task",
"name": "PID",
"MOs": ["hNClusters"]
}]
},
"TrackClusterCheck": {
"active": "true",
"className": "o2::quality_control_modules::tpc::TrackClusterCheck",
"moduleName": "QcTPC",
"policy": "OnAny",
"dataSource": [{
"type": "Task",
"name": "Tracks",
"MOs": ["hNClustersBeforeCuts"]
}]
}
}
We would like to ask if it would be possible to introduce something similar also in the trending, like grouping the histograms with the same path and same reductorName (e.g. TH1-Reductor). Or are there some computational inefficiencies which are preventing it?
- We also noticed that only the TH1 histograms are implemented in
TrendingTask
. Are there plans to implement in the Framework also the TH2 histograms and the addition of the checkers, as the corresponding reductorsQualityControl/Modules/Common/.../TH2Reductor.*
andQualityControl/Modules/Common/.../QualityReductor.*
already exist?
Best,
Marcel and Cindy